Committing test css buttons#1934
Committing test css buttons#1934neufke wants to merge 11 commits intophpbb:developfrom neufke:develop
Conversation
There was a problem hiding this comment.
agreed but like the removal of images, didn't want to make it too formal when its only for reviewing... ;-)
There was a problem hiding this comment.
what are you talking about why would we want to approve something that is flawed? Should we no be practicing and requiring componetized improvements to the css base inorder to progress.
CSS is not programatic and as such should have a different set of rules to follow for RFCs...
http://midaym.com/Mino/phpbb-tests/buttons.html
anyway here is an example of a better approach, i used the github octicons font for the icons which is unlicensed without support per here: octokit/octokit.objc#108 unfortunately they are optimized for 16px but I argue that the text on the original buttons is two small as the overall thing is 16px! because it was an icon by design and not a button.
There was a problem hiding this comment.
I think you are missing the point...
There was a discussion @area51 where i asked if the mini-buttons would be changed to css too. nickvergessen replied that that would be the case BUT the difficulty was the small font size.
So i did a local css test which came out nicely and i added some screenshots to the thread showing the result. I then asked that, if anyone would be interested i could give them the code. The reply was to put it on github so it could be reviewed....
...and that is what i did. You assume that css needs to be of version 2.1, but where does it say so?
You are commenting on code that is being deleted (because it is outdated), you create an example that is really nice but at the same time doesn't even closely match the prosilver theme etc.etc.
Long story short, we are discussing the possibility of css-ing the mini-buttons and we are reviewing testcode i made just to see if the problems with the small font can be solved... that's all....
;-)
There was a problem hiding this comment.
i understand and i read it i will put my response in that discussion to avoid confusion in the future if need be. I only posted here to try and offer suggestions to the repo that is already started rather than direct attention somewhere else.
To clarify...
- I do not assume anything, CSS 3.0 should be used where possible, CSS 1.0 has not been used as the only version of css in a browser since IE 6! <- The dominant browser during prosilver's origins
- Pre tagging classes with anchors is not part of any spec I have seen for CSS 1.0? Its a scope/specificity hack that was adopted by some at the time and has since been abandoned by the masses due to the amount of chars in a file served being more important than small advantages of specificity which due not even hold up in the newer versions of the language
- naderman has stated many times that he is completely fine with not giving IE6 the same love as the newer browsers.
- I am not commenting on any specific piece of code I just added the comment to this line as an example for my first comment. To show that the original naming convention and specificity was still being used for an enhancement.
With all that hopefully clearing up my points and discussions I will concede to your last statement however As I read the post it was not clear that you are only testing the font-size
There was a problem hiding this comment.
To point # 3... Some of the recent changes to Prosilver have already broken compatibility with IE 6 (the navrbar links with clickable icons, for example). So it's pretty safe to say the phpBB is no longer considering IE 6 compatibility. And that's a good thing, since only Chinese spammers use IE 6 these days, and we don't want them on our forums anyway! :) Seriously though, anyone using IE 6 these days MUST be used to sites not working or looking right, so it's their choice and their loss.
There was a problem hiding this comment.
I agree, and it would be a nice discussion. Microsoft server 2008 R2 is the IIS environment in the largest companies with terminal services on 8500 machines running winXP. IT departments can choose to update to IE8 (there simply is nothing higher for winXP on terminal machines) or stay @IE6 or, the third option, replace every piece of software within the corporation (what would cost millions...) or keep running ie6... Like i said, it would be a nice discussion.
For now, let's get back to the question here, what do you think, should we go with css-ing of the mini-buttons, is the font chosen by me acceptable, do we still use some of the outdated icons (msn for example) etc. ?? Let me know please
|
I was still waiting for the final answer to the question if this font size is acceptable so we overcame that problem. I would be happy to make a new commit according to the coding guidelines... Merry x-mas to all! |
According to coding guidelines
Been fiddling with the code a bit, is workingnow
Be gentle, from subversion to github isn't even a giant leap, it is a universe of difference... ;-)
see http://area51.phpbb.com/phpBB/viewtopic.php?f=81&p=259507 for a discussion of css-ing the mini buttons