[ticket/12793] String '0' does not display for string profile fields#2718
Merged
nickvergessen merged 3 commits intophpbb:develop-ascraeusfrom Jul 27, 2014
Merged
[ticket/12793] String '0' does not display for string profile fields#2718nickvergessen merged 3 commits intophpbb:develop-ascraeusfrom
nickvergessen merged 3 commits intophpbb:develop-ascraeusfrom
Conversation
Contributor
Author
|
phpbb_profilefield_type_string_test::test_get_profile_value_raw with data set #3 (0, array(false), NULL, 'Field should return null for empty integer without show_novalue') Field should return null for empty integer without show_novalue Failed asserting that 0 is identical to null. We are not treating 0 as null from now on. |
Contributor
There was a problem hiding this comment.
please change this function to return $this->get_profile_value_raw($field_value, $field_data);
…e_raw Changing the return to get_profile_value_raw PHPBB3-12793
changed behavieur of 0 as in and added 0 as string test PHPBB3-12793
nickvergessen
added a commit
to nickvergessen/phpbb
that referenced
this pull request
Jul 27, 2014
[ticket/12793] String '0' does not display for string profile fields * lucifer4o/ticket/12793: [ticket/12793] Tests (added and changed) [ticket/12793] Changing get_profile_contact_value to get_profile_value_raw [ticket/12793] String '0' does not display for string profile fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2647 (comment)
Found this before going to work.
PHPBB3-12793