[ticket/15148] Covert contact menu to svg (Retina) #4765
[ticket/15148] Covert contact menu to svg (Retina) #4765hanakin wants to merge 14 commits intophpbb:masterfrom hanakin:ticket/15148
Conversation
|
this is ready for review |
|
Did you change the speech balloon, too? I prefer the round one. @Mail-Icon: I don't like it, because I think it is not clear, what is meant. Personally I'd to look at the info-popup to see what this is. Guessed at a social media thing, I don't know. In addition FB, YT and e-mail look a bit blurry to me. In the profil is still a text list, maybe the icons would fit there, too: /phpBB/memberlist.php?mode=viewprofile&u=xy |
|
@Crizz0 blurry in the screengrab? cause thats irrelevant. Otherwise if something is blurry it may be your setup as its impossible for svgs to be blurry? The email icon is the gmail icon we can always swap it out as for the "speech ballon" not sure what you mean |
|
It looks to me, that the inner "f" of Facebook looks a bit blurry. Don't know if this is a screen problem or my eyes. :( Edit: Okay, my eyes are fine. My desktop-display is not. Everything fine with my smartphone for example. So all good. @"speech ballon": I mean this one: |
|
yeah if its blurry then its your eyes or your setup. As for the contact icon i swapped it out for GMDs version as its painful to convert fa icons to properly formated svgs. plus its a better design IMHO and matches the pm icon better |
|
I see that point with the PM icon. But I think we should swap out the mail icon. Maybe an open envelope with an @ in it or similar. |
|
updated email icon?
|
| width: 24px; | ||
| height: 24px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should be only one empty new line
| /> | ||
| </g> | ||
| </symbol> | ||
| <symbol id="pm" viewBox="0 0 24 24"> |
There was a problem hiding this comment.
Any reason why half of the icons have a phpBB prefix and the others don't? I'd rather use prefixes for all contact icons than not mixing this or not having a prefix. Especially since IDs are somewhat invasive in their nature of wanting to be unique.
There was a problem hiding this comment.
@marc1706 thats a db thing(hard coded) as those ones require db integration for some reason. This was the simplest way handle things without a lot of investigation and core editing
|
here is all the included icons
|
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15148
PHPBB3-15156
PHPBB3-15148
|
should hold off on this until icon rework... |
|
closing this until we build icon twig function |
Checklist:
Ticket/15148
https://tracker.phpbb.com/browse/PHPBB3-15148
Examples
This is a test case for the full icon conversion to svg. all icons will be broken down into sets(html or twig files) of relatable icons and each file file be include at the top of the page. You can see the sets I have in mind here: http://codepen.io/hanakin/pen/XMBaaV?editors=1100