Use php-cs-fixer/shim instead + full Symfony 8 support#1128
Use php-cs-fixer/shim instead + full Symfony 8 support#1128dantleech merged 3 commits intophpbench:masterfrom
Conversation
|
This is still not installing Symfony 8. I fear that without Flex enforcing it, Composer prefers the stable version. |
|
Seeing https://github.com/phpbench/phpbench/actions/runs/19114176412/job/54631434251, I'm not sure to understand why it does not install Symfony 8 beta packages:
However, running |
|
Because you're forcing Composer's SAT solver to use the beta; it seems that, if it's left with the choice, it prefers the stable tag. We need Flex and its forced requirement. |
e925566 to
f346e43
Compare
f346e43 to
24d7bdc
Compare
|
Added Flex and updated the pinned version of |
|
container 2.2.3 was tagged. still seems odd that Symfny seems to require a special tool to install it, given a choice I'd rather just |
Can you please restart the CI?
Flex does a lot more than that, because it locks down all Symfony components, so it influences indirect dependencies too. In the past I had issues without that because it can mix different major versions, leading to strange bugs in CI. |
|
ok, looks like we've uncovered actual incompatibilit(y|ies) now |
|
|
|
Aaaand it's all green now, PHPBench can now fully run on Symfony 8 :) PS: I really like the |
|
awesome, thanks for this, will tag later today or tomorrow |
|
Perfect, thanks :) |
|
great job guys, thank you! |
Follows #1125