Skip to content

Fix .gitignore#20249

Merged
MauricioFauth merged 2 commits intophpmyadmin:masterfrom
liviuconcioiu:gitignore
Mar 21, 2026
Merged

Fix .gitignore#20249
MauricioFauth merged 2 commits intophpmyadmin:masterfrom
liviuconcioiu:gitignore

Conversation

@liviuconcioiu
Copy link
Contributor

@liviuconcioiu liviuconcioiu commented Mar 21, 2026

Description

After #20248, I got this:

git

If I discard those files (eg. when trying to make a PR and avoid those files being added), phpMyAdmin is no longer browseable.

discard

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@liviuconcioiu
Fix .gitignore
93029bb 
Signed-off-by: Liviu-Mihail Concioiu <[email protected]>
@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.52%. Comparing base (f3363a3) to head (93029bb).
⚠️ Report is 8176 commits behind head on master.

Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #20249       +/-   ##
=============================================
+ Coverage     49.50%   63.52%   +14.01%     
+ Complexity    16854    16060      -794     
=============================================
  Files           607      676       +69     
  Lines         69655    59891     -9764     
=============================================
+ Hits          34486    38044     +3558     
+ Misses        35169    21847    -13322
Flag Coverage Δ
dbase-extension 63.46% <ø> (?)
unit-7.3-ubuntu-latest ?
unit-7.4-ubuntu-latest ?
unit-8.1-ubuntu-latest ?
unit-8.2-ubuntu-latest 63.45% <ø> (+14.10%) ⬆️
unit-8.3-ubuntu-latest 63.45% <ø> (+14.11%) ⬆️
unit-8.4-ubuntu-latest 63.41% <ø> (+14.00%) ⬆️
unit-8.5-ubuntu-latest 63.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MauricioFauth
MauricioFauth requested changes Mar 21, 2026
View reviewed changes
Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liviuconcioiu @MauricioFauth
Update .gitignore
09a65b3 
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
@liviuconcioiu
Copy link
Contributor Author

liviuconcioiu commented Mar 21, 2026

@MauricioFauth should I also replace this?

!/public/themes/bootstrap/
!/public/themes/metro/
!/public/themes/original/
!/public/themes/pmahomme/

with

!/public/themes/*/

@MauricioFauth MauricioFauth merged commit 1836078 into phpmyadmin:master Mar 21, 2026
40 of 42 checks passed
@liviuconcioiu liviuconcioiu deleted the gitignore branch March 21, 2026 19:55
@MauricioFauth
Copy link
Member

MauricioFauth commented Mar 21, 2026

should I also replace this?

No, because we want to ignore all themes, except for these ones.

@MauricioFauth MauricioFauth self-assigned this Mar 21, 2026
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@liviuconcioiu @MauricioFauth