Fix crash on MethodCallableNode on do while#3752
Open
samsonasik wants to merge 1 commit intophpstan:2.1.xfrom
Open
Fix crash on MethodCallableNode on do while#3752samsonasik wants to merge 1 commit intophpstan:2.1.xfrom
samsonasik wants to merge 1 commit intophpstan:2.1.xfrom
Conversation
Contributor
Author
|
Ready to merge 👍 |
ondrejmirtes
requested changes
Dec 23, 2024
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
- MethodCallableNode is not the only one with this problem. There's also FunctionCallableNode, InstantiationCallableNode, StaticMethodCallableNode. Please reproduce and fix issues with them too.
- Crashing examples have regression tests in AnalyserIntegrationTest, not in a specific rule. Because we're not fixing an error in a specific rule.
- Printing of custom nodes is fixed by adding a method on PHPStan\Node\Printer\Printer, not by modifying ExprPrinter.
Thanks.
Contributor
Author
|
I will try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#12246
Ref https://phpstan.org/r/178ac73a-e99c-4961-957f-a3c6062d7c44
Ref https://3v4l.org/5s30L