Fix argument count mismatches revealed by PHP 7.1#24
Merged
h6w merged 1 commit intophpvirtualbox:developfrom Oct 26, 2017
mikedld:php71
Merged
Fix argument count mismatches revealed by PHP 7.1#24h6w merged 1 commit intophpvirtualbox:developfrom mikedld:php71
h6w merged 1 commit intophpvirtualbox:developfrom
mikedld:php71
Conversation
h6w
added a commit
that referenced
this pull request
May 8, 2017
…ewer Patch contributed for #24 Allow usage of SparkGateway or Guacamole instead of Java viewer
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 27, 2017
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@446746 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 27, 2017
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of)
Contributor
|
ech 7.1 looks messy. So many unnecessary nulls! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've upgraded to PHP 7.1 recently and phpvirtualbox stopped working because of errors (which were only warnings before). This fixes as much as I stumbled upon during limited testing. If not enough, should at least help someone else to get started.