Adding a new AwardClass for Flight Time#869
Merged
nabeelio merged 6 commits intophpvms:devfrom Oct 13, 2020
Merged
Conversation
This award is based on the original PilotFlightAwards.php file but checks the Pilots Flight Time (In Minutes). This award means you can create an award for a pilot that completes any amount of flight time (In Minutes).
nabeelio
reviewed
Oct 13, 2020
Small Correction suggested via Review, to check that that value of $flight_minutes is infact an int
added an additional check that $flight_minutes is an int if provided by the user.
nabeelio
reviewed
Oct 13, 2020
Added the Log function if the user enters a non int value in the ui
Cleaning up some unneeded code due to the new input validation based on is_int()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This award is based on the original PilotFlightAwards.php file but checks the Pilots Flight Time (In Minutes).
This award means you can create an award for a pilot that completes any amount of flight time (In Minutes).