Conversation
Contributor
|
Great
Oh okay, got it. |
YashGovekar
reviewed
Oct 21, 2020
Contributor
YashGovekar
left a comment
There was a problem hiding this comment.
Ahh great! Took a bit to understand the code.
So finally all the module bugs have been solved :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something of a race condition happens when there are module migrations pending, but they're not picked up when the migration hasn't yet been loaded. This is an issue when there is seed data which depends on the migrations to run. So, before running the seeds, check for any pending migrations, but also in the installer, after running the initial migrations, check again for pending migrations, where the initial sets of modules that are running would have been loaded in.
cc @YashGovekar