Skip to content

Update Metar Decoding (Text Correction Only)#950

Merged
nabeelio merged 3 commits intophpvms:devfrom
FatihKoz:patch-5
Dec 4, 2020
Merged

Update Metar Decoding (Text Correction Only)#950
nabeelio merged 3 commits intophpvms:devfrom
FatihKoz:patch-5

Conversation

@FatihKoz
Copy link
Copy Markdown
Contributor

@FatihKoz FatihKoz commented Dec 4, 2020

SKC means Sky Clear or Clear Skies. , it is not used as an acronym for No Significant Changes Expected (which is NOSIG)

Rest is ok

SKC means Sky Clear or Clear Skies.

Rest is ok
@nabeelio nabeelio added the bug label Dec 4, 2020
@nabeelio nabeelio added this to the 7.0.0 milestone Dec 4, 2020
@nabeelio
Copy link
Copy Markdown
Member

nabeelio commented Dec 4, 2020

There is a test failing, can you update file too? If you click "Details" in the "Travis CI - Pull Request" and click one of the runtimes; here's the error:

1) Tests\MetarTest::testMetar1
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'A few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters'
+'Few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters'
/home/travis/build/nabeelio/phpvms/tests/MetarTest.php:68

@FatihKoz
Copy link
Copy Markdown
Contributor Author

FatihKoz commented Dec 4, 2020

I just delete the -a- from 'A few' and capitalized the first letter like 'Few' , failing to build just for one letter is strange. If you wish I can redo the complete process.

@nabeelio
Copy link
Copy Markdown
Member

nabeelio commented Dec 4, 2020

Yeah just go to here tests/MetarTest.php:68 and fix the text. And check if there are any others that are changed. Builds will fail if any tests fail. I have tests for as much stuff as possible - including some of these texts to make sure nothing breaks any accident.

@nabeelio
Copy link
Copy Markdown
Member

nabeelio commented Dec 4, 2020

You can go to "open with" in the top right and either clone this branch to your desktop, or use codespaces

@FatihKoz
Copy link
Copy Markdown
Contributor Author

FatihKoz commented Dec 4, 2020

Downloaded the desktop app and made the change as a commit. Hope it passes the build test this time

@nabeelio
Copy link
Copy Markdown
Member

nabeelio commented Dec 4, 2020

Thank you!

@nabeelio nabeelio merged commit fb44b73 into phpvms:dev Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants