Update DownloadController.php#962
Merged
nabeelio merged 3 commits intophpvms:devfrom Dec 18, 2020
FatihKoz:patch-5
Merged
Conversation
Changed the group name according to its category , aircrafts will show icao type and registration , airports will be displayed with their icao codes names and countries. Rest will be showed with their names (exp airlines) This will result a much better look on the downloads page for end users while looking for a specific type's files (like a repaint for a B738).
Contributor
Author
|
I am no longer trying to fix ridiculous style errors styleci finds @nabeelio , sorry for that ...
It is fine on my end and works fine ... Just downloaded vscode , used it for changes , even tried sending a pr with github desktop it always finds silly style errors while the code is clean and tidy. So if you want to reject, it is ok for me will never spend my time for it again. |
Member
|
Fixed it for you, will merge once it passes |
Contributor
Author
|
Thanks for your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the group name according to its category , aircrafts will show icao type and registration , airports will be displayed with their icao codes names and countries. Rest will be showed with their names (exp airlines)
This will result a much better look on the downloads page for end users while looking for a specific type's files (like a repaint for a B738).