Skip to content

parser: fix some parse error for parenthese subqueries#1255

Merged
ti-chi-bot merged 14 commits intopingcap:masterfrom
lzmhhh123:bug-fix/try_fix
Aug 16, 2021
Merged

parser: fix some parse error for parenthese subqueries#1255
ti-chi-bot merged 14 commits intopingcap:masterfrom
lzmhhh123:bug-fix/try_fix

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 commented Jun 22, 2021

Signed-off-by: lzmhhh123 [email protected]

What problem does this PR solve?

close #1127

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

lzmhhh123 added 3 commits June 18, 2021 14:55
@lzmhhh123
try fix
8722804 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
tmp
30833d3 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix and add test
9f09f4a 
Signed-off-by: lzmhhh123 <[email protected]>
lzmhhh123 added 7 commits June 22, 2021 11:01
@lzmhhh123
Merge remote-tracking branch 'origin/master' into bug-fix/try_fix
f7346ed 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
326cb00 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
82dd3ee 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
adda8f7 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
tmp
2a92917 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
aeff810 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
4c31d76 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

lzmhhh123 commented Jun 24, 2021

/rebuild

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

lzmhhh123 commented Jul 2, 2021

/rebuild

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Aug 16, 2021

Please resolve the conflicts~

xiongjiwei
xiongjiwei reviewed Aug 16, 2021
View reviewed changes
@lzmhhh123
address comments
72ff777 
Signed-off-by: lzmhhh123 <[email protected]>
@lzmhhh123
fix
229f95e 
Signed-off-by: lzmhhh123 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 16, 2021
@lzmhhh123 lzmhhh123 added needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-rebase and removed status/LGT2 LGT2 labels Aug 16, 2021
@xiongjiwei
Copy link
Copy Markdown
Contributor

xiongjiwei commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 229f95e

@ti-chi-bot ti-chi-bot merged commit b4bbfae into pingcap:master Aug 16, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

In response to a cherrypick label: cannot checkout 5.2: error checking out 5.2: exit status 1. output: error: pathspec '5.2' did not match any file(s) known to git

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

In response to a cherrypick label: cannot checkout 5.0: error checking out 5.0: exit status 1. output: error: pathspec '5.0' did not match any file(s) known to git

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

In response to a cherrypick label: cannot checkout 5.1: error checking out 5.1: exit status 1. output: error: pathspec '5.1' did not match any file(s) known to git

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

lzmhhh123 commented Aug 17, 2021

/run-cherry-picker

bb7133 pushed a commit that referenced this pull request Aug 17, 2021
@lzmhhh123
parser: fix some parse error for parenthese subqueries (#1255) (#1308)
a02f7a0
@lzmhhh123 lzmhhh123 deleted the bug-fix/try_fix branch August 19, 2021 07:43
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Sep 3, 2021

/run-cherry-picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 Type: Need cherry pick to release 5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 status/can-merge status/LGT2 LGT2 type/bug-fix fix bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tidb reports syntax error while mysql does not

5 participants

@lzmhhh123 @ti-chi-bot @bb7133 @xiongjiwei @wjhuang2016