parser: ensure NOT NOT EXISTS is the same as EXISTS (#1254)#1265
Merged
tiancaiamao merged 1 commit intopingcap:release-5.0from Jul 5, 2021
Merged
parser: ensure NOT NOT EXISTS is the same as EXISTS (#1254)#1265tiancaiamao merged 1 commit intopingcap:release-5.0from
tiancaiamao merged 1 commit intopingcap:release-5.0from
Conversation
tangenta
approved these changes
Jul 5, 2021
tiancaiamao
approved these changes
Jul 5, 2021
ti-srebot
approved these changes
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1254 to release-5.0
What problem does this PR solve?
Fix #1251
What is changed and how it works?
When applying NOT to an ExistsSubqueryExpr, flip its
Notflag instead of always setting it totrue.Check List
Tests
Code changes
Side effects
Related changes
NOT NOT EXISTS (SELECT ...)is now correctly interpreted asEXISTS (SELECT ...).