Search PATH when .pex is invoked at a relative path with no /#299
Open
chrisnovakovic wants to merge 1 commit intoplease-build:masterfrom
Open
Search PATH when .pex is invoked at a relative path with no /#299chrisnovakovic wants to merge 1 commit intoplease-build:masterfrom
PATH when .pex is invoked at a relative path with no /#299chrisnovakovic wants to merge 1 commit intoplease-build:masterfrom
Conversation
In the preamble, mimic a shell's `PATH` searching behaviour when determining the path to the .pex file if it was invoked via a relative path name containing no `/` characters. Assuming the output of a hypothetical `python_binary` with the run-time interpreter search path `python3` has been copied to `/usr/bin/out.pex`, this will cause the Python interpreter to be invoked using the arguments on the right-hand side when the .pex file is invoked using the argument on the left-hand side: - `/abs/path/out.pex` -> `python3 /abs/path/out.pex` - `rel/path/out.pex` -> `python3 rel/path/out.pex` - `out.pex` -> `python3 /usr/bin/out.pex` Fixes please-build#298.
Contributor
Author
|
I've also written a regression test for this, but it won't pass until this PR gets merged and a new version of please_pex is released. |
toastwaffle
reviewed
Apr 9, 2026
|
|
||
| // Construct a candidate path by concatenating the next directory in PATH and the file name | ||
| // we were given. | ||
| if (dir_start == dir_end) { |
Contributor
There was a problem hiding this comment.
I'm not clear on what this case is handling, so probably deserves a comment. Empty path entry meaning resolve relative to the current working directory?
| } | ||
|
|
||
| FREE(*res_path); | ||
| } while (*dir_end++ == ':'); |
Contributor
There was a problem hiding this comment.
I'm not clear on how we avoid an out-of-bounds memory access in all of this. I'm sure I'm just missing something, but would appreciate a pointer (pun intended)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the preamble, mimic a shell's
PATHsearching behaviour when determining the path to the .pex file if it was invoked via a relative path name containing no/characters.Assuming the output of a hypothetical
python_binarywith the run-time interpreter search pathpython3has been copied to/usr/bin/out.pex, this will cause the Python interpreter to be invoked using the arguments on the right-hand side when the .pex file is invoked using the argument on the left-hand side:/abs/path/out.pex->python3 /abs/path/out.pexrel/path/out.pex->python3 rel/path/out.pexout.pex->python3 /usr/bin/out.pexFixes #298.