Support for Spark/Scala parametrized docker build#968
Support for Spark/Scala parametrized docker build#968syspulse wants to merge 1 commit intopolynote:masterfrom
Conversation
|
Hi and welcome @syspulse! Appreciate this contribution, but I have to admit some noob-ism when it comes to docker. Can you describe a little bit what the repercussions of your changes are when it comes to the build process, the install process, etc? |
|
I think the repercussion is the docker build: https://github.com/polynote/polynote/blob/master/.github/workflows/dist.yml echo "${DOCKER_PASSWORD}" | docker login -u ${DOCKER_USERNAME} --password-stdin export SPARK_VERSION="2.4.7" export SCALA_VERSION="2.12" export SPARK_VERSION="2.4.7" export SPARK_VERSION="3.0.1" |
Refactored a little bit docker builds to support:
To avoid default parameters mistakes SPARK_VERSION and SCALA_VERSION are mandatory now (example shell scripts included)