Skip to content

Allow TOML 1.0.0 syntax in check-toml#608

Closed
hukkin wants to merge 1 commit intopre-commit:masterfrom
hukkin:toml-1.0.0
Closed

Allow TOML 1.0.0 syntax in check-toml#608
hukkin wants to merge 1 commit intopre-commit:masterfrom
hukkin:toml-1.0.0

Conversation

@hukkin
Copy link
Copy Markdown

@hukkin hukkin commented Jun 2, 2021

check-toml fails with new TOML 1.0.0 syntax. This changes the TOML parser used to a spec v1.0.0 compatible one. Disclaimer: the parser used is written by me.

@asottile
Copy link
Copy Markdown
Member

asottile commented Jun 2, 2021

no thanks, toml is the ubiquitous library used in the python community -- surely it will be updated at some point

@asottile asottile closed this Jun 2, 2021
@hukkin hukkin deleted the toml-1.0.0 branch June 2, 2021 14:16
@hukkin
Copy link
Copy Markdown
Author

hukkin commented Jun 2, 2021

I respect that. You may be interested to know that Tomli is about to be vendored in pip, so pip will use it to read pyproject.toml.

@DanielNoord
Copy link
Copy Markdown
Contributor

@asottile Seeing as tomli is now included as tomllib in 3.11, would you want a PR that switches to tomli similar to python/mypy#12305 / pytest-dev/pytest#9741?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants