Skip to content

Fix referencing a type from another package in the same preconstruct build that has a .d.ts file at the entrypoint#602

Merged
emmatown merged 1 commit intomainfrom
fix-referencing-type-from-dts-package-in-another-package
Oct 1, 2024
Merged

Fix referencing a type from another package in the same preconstruct build that has a .d.ts file at the entrypoint#602
emmatown merged 1 commit intomainfrom
fix-referencing-type-from-dts-package-in-another-package

Conversation

@emmatown
Copy link
Copy Markdown
Member

@emmatown emmatown commented Oct 1, 2024

This will fix emotion-js/emotion#3259

…build that has a `.d.ts` file at the entrypoint
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: ad2a59d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (4b920e7) to head (ad2a59d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   92.40%   92.45%   +0.04%     
==========================================
  Files          39       39              
  Lines        2081     2081              
  Branches      655      655              
==========================================
+ Hits         1923     1924       +1     
+ Misses        147      146       -1     
  Partials       11       11              
Flag Coverage Δ
92.45% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmatown emmatown merged commit b62bd19 into main Oct 1, 2024
@emmatown emmatown deleted the fix-referencing-type-from-dts-package-in-another-package branch October 1, 2024 00:22
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
@emmatown emmatown restored the fix-referencing-type-from-dts-package-in-another-package branch November 22, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import issues - Cannot find name 'EmotionCache'

1 participant