fix(serverless): gracefully fail with 400 for null body#38
Merged
gr2m merged 2 commits intoprobot:masterfrom Sep 17, 2020
Merged
fix(serverless): gracefully fail with 400 for null body#38gr2m merged 2 commits intoprobot:masterfrom
gr2m merged 2 commits intoprobot:masterfrom
Conversation
Contributor
Author
|
@JasonEtco any chance you can help get this looked at? Thanks! |
JasonEtco
reviewed
Aug 25, 2020
This partially reverts commit f61540f.
|
🎉 This PR is included in version 0.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is apparently possible to get a null
event.bodyfrom API Gateway. Right now, this leads to a TypeError at thisconsole.logstatement due to the access ofevent.body.action. This PR adds logic to gracefully fail early with a 400 error.