Skip to content

Fix for #5625 - Made tab widths consistent across renderers#5633

Merged
benfry merged 2 commits intoprocessing:masterfrom
liquidev:master
Aug 30, 2018
Merged

Fix for #5625 - Made tab widths consistent across renderers#5633
benfry merged 2 commits intoprocessing:masterfrom
liquidev:master

Conversation

@liquidev
Copy link
Copy Markdown
Contributor

Fortunately this is a very easy fix, just replace all tabs with spaces (I chose 4 as this is what I use as my tab width in text editors, however this should be subject to change. Maybe make a tabWidth() function?)

Made tab widths consistent across renderers
@benfry
Copy link
Copy Markdown
Contributor

benfry commented Aug 30, 2018

Interesting fix… I'd rather get to the source of the problem, but I think this is rare enough that it's ok to go this route.

@liquidev
Copy link
Copy Markdown
Contributor Author

I know that this fix is not very accurate, because tabs are supposed to help with making tables etc. but I might create a better fix at some other point in time.

@clankill3r
Copy link
Copy Markdown

I am pretty sure you just broke textWidth, you need to replace the tabs there as well.

@jeremydouglass
Copy link
Copy Markdown
Contributor

Don't break textWidth! I like the idea of this change, but if it comes down to a choice I personally I think supporting dynamic typography logic is more important than cross-renderer consistency. My two cents.

@liquidev
Copy link
Copy Markdown
Contributor Author

liquidev commented Sep 5, 2018

@clankill3r I didn't think about that possibility, I'll make a new version of this, fixing the broken fix that breaks things.

@benfry
Copy link
Copy Markdown
Contributor

benfry commented Sep 14, 2018

Ok, backing out that fix. We'd need to add that hack to 4-5 places in the code, and it still wouldn't cover text from char[] arrays and it doesn't actually implement tab support anyway.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants