Only suggest template files with valid template names#305
Open
JanRomero wants to merge 1 commit intoprocesswire:devfrom
Open
Only suggest template files with valid template names#305JanRomero wants to merge 1 commit intoprocesswire:devfrom
JanRomero wants to merge 1 commit intoprocesswire:devfrom
Conversation
…r->templateName()`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using periods in template filenames, these files would be suggested in the Add Template screen. However, when you would choose such a file, say “my.template.php”, the resulting template name would become “my-template”. You would then be notified that the template lacks a file, even though you created it from ProcessWire’s file suggestion.
This PR uses the same sanitizer method
templateName()to filter suggested files which is also used to sanitize template names. Before, onlyname()was used, which allows periods. Thus, “my.template.php” is no longer suggested.In my case, that’s what I want anyway, because I’m using the period to denote partials related to the template.
Thank you!