Add helpful information for why module cannot be uninstalled#307
Open
artfulrobot wants to merge 1 commit intoprocesswire:devfrom
Open
Add helpful information for why module cannot be uninstalled#307artfulrobot wants to merge 1 commit intoprocesswire:devfrom
artfulrobot wants to merge 1 commit intoprocesswire:devfrom
Conversation
ffdf9f2 to
9a45104
Compare
poljpocket
suggested changes
Jul 1, 2025
Contributor
poljpocket
left a comment
There was a problem hiding this comment.
Your sprintf changes don't really work correctly right now.
Contributor
|
Also, you should always request a PR against the |
9a45104 to
dff07b9
Compare
dff07b9 to
feaf2c4
Compare
5883251 to
210f9c3
Compare
Author
|
@poljpocket Took an embarrassing number of tries to get the formatting correct, but I think I got there in the end! 😆
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
poljpocket
reviewed
Jul 1, 2025
210f9c3 to
21e8e32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to uninstall a module you get a message if you can't because other modules depend on it, or because a field uses it. But you're not told which one. As this info is not listed anywhere else, it's quite hard to find out why.
This PR simply adds to the explanation text: