Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields#314
Open
tuomassalo wants to merge 4 commits intoprocesswire:devfrom
Open
Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields#314tuomassalo wants to merge 4 commits intoprocesswire:devfrom
tuomassalo wants to merge 4 commits intoprocesswire:devfrom
Conversation
…E pages_id=... when creating a new page
Contributor
Author
|
I added another commit that removes an unnecessary Unfortunately, the delete query is not visible with I did not have time to find out why not all queries show with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when saving pages, the value of each
PageandPageTablefield is queried. With a big number of such fields this is bad for performance.I
believeguess this PR is safe since Fieldtype.php already has identical logic.Here's a script to reproduce the extra select: