Shutdown HTTPServer executor service to avoid non-daemon threads potentially blocking exiting JVM#303
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Oct 16, 2017
marcelmay:httpserver-clean-shutdown
Merged
Shutdown HTTPServer executor service to avoid non-daemon threads potentially blocking exiting JVM#303brian-brazil merged 1 commit intoprometheus:masterfrom marcelmay:httpserver-clean-shutdown
brian-brazil merged 1 commit intoprometheus:masterfrom
marcelmay:httpserver-clean-shutdown
Conversation
…cking exiting JVMs.
Contributor
Author
|
Just saw related PR #300 |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTPServer creates a Java ExecutorService but does not shut it down when stopping the HTTPServer.
As the default executor service creates non-daemon threads, this will cause the JVM to hang if the JVM does not exist using a forced System.exit(...).
@brian-brazil : This happens currently when using the latest jmx_exporter (disable the System.exit(...) in TestApplication to reproduce/verify).