SimpleCollecor.labels() initialization performance#307
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Nov 30, 2017
mcoolive:master
Merged
SimpleCollecor.labels() initialization performance#307brian-brazil merged 1 commit intoprometheus:masterfrom mcoolive:master
brian-brazil merged 1 commit intoprometheus:masterfrom
mcoolive:master
Conversation
- Now, we do 3 lookups in the children Map when we create a new tupple of labels. From my understanding, it's to manage concurrent initializations. It can be improved. I suggest to check the result of 'putIfAbsent' to avoid the third lookup. Because we do not want to create a new Child for each call to #labels, I don't find a solution with only 1 lookup. BUT with Java 8, we can consider the use of 'computeIfAbsent' with a lambda.
Author
|
An opinion would be welcome. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labels. From my understanding, it's to manage concurrent initializations.
It can be improved. I suggest to check the result of 'putIfAbsent' to avoid the third
lookup.
Because we do not want to create a new Child for each call to #labels, I
don't find a solution with only 1 lookup. BUT with Java 8, we can consider
the use of 'computeIfAbsent' with a lambda.