Better metric name sanitizer in Dropwizard exporter#314
Merged
brian-brazil merged 2 commits intoprometheus:masterfrom Nov 10, 2017
apesternikov:master
Merged
Better metric name sanitizer in Dropwizard exporter#314brian-brazil merged 2 commits intoprometheus:masterfrom apesternikov:master
brian-brazil merged 2 commits intoprometheus:masterfrom
apesternikov:master
Conversation
Contributor
|
Thanks! |
johnrengelman
pushed a commit
to ratpack/ratpack
that referenced
this pull request
Jan 11, 2018
Added to Prometheus lib in prometheus/client_java#314.
|
Is there a chance this could get release in a patch release (0.1.1?) Trying to integrate prometheus into ratpack and we need to deal with metrics that start with a digit. |
Contributor
|
I'll put a release on my todo list. |
|
^ any idea when this might happen? Would be really helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for (#313)
@brian-brazil please review.