Produce metric for max thread pool size#319
Merged
brian-brazil merged 4 commits intoprometheus:masterfrom Dec 1, 2017
Merged
Conversation
brian-brazil
reviewed
Dec 1, 2017
| QueuedThreadPool::getIdleThreads), | ||
| buildGauge("jetty_queued_thread_pool_jobs", "Number of total jobs", | ||
| QueuedThreadPool::getQueueSize), | ||
| buildGauge("jetty_queued_thread_pool_max", "Max size of thread pool", |
Contributor
There was a problem hiding this comment.
I don't think you've got the right function.
Contributor
Author
There was a problem hiding this comment.
I think you're right 🤦♂️
brian-brazil
reviewed
Dec 1, 2017
| buildGauge("jetty_queued_thread_pool_jobs", "Number of total jobs", | ||
| QueuedThreadPool::getQueueSize)); | ||
| QueuedThreadPool::getQueueSize), | ||
| buildGauge("jetty_queued_thread_pool_max", "Max size of thread pool", |
Contributor
There was a problem hiding this comment.
threads_max would seem more in line with the above metrics
Contributor
Author
There was a problem hiding this comment.
Perhaps. Or would size be more appropriate?
Contributor
There was a problem hiding this comment.
I'd say that it's implicit that it's the maximum size of the threadpool, there's nothing else it can really be the max of.
Contributor
|
Thanks! |
Contributor
Author
|
Thanks for your time, much obliged :-) |
|
Sorry if this the wrong channel to ask, but I am wondering why this is done for jdk8 only and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to measure and alert on capacity