Skip to content

add processCpuLoad metric for StandardExports#436

Closed
chanjarster wants to merge 1 commit intoprometheus:masterfrom
chanjarster:master
Closed

add processCpuLoad metric for StandardExports#436
chanjarster wants to merge 1 commit intoprometheus:masterfrom
chanjarster:master

Conversation

@chanjarster
Copy link
Copy Markdown

@chanjarster chanjarster commented Nov 3, 2018

@brian-brazil add processCpuLoad(since 1.7) metric for StandardExports. According to javadoc this is process-level metric.

@brian-brazil
Copy link
Copy Markdown
Contributor

These are machine level metrics, it's the responsibility of the node exporter to export those - not individual applications.

@chanjarster
Copy link
Copy Markdown
Author

@brian-brazil I agree with you about "committedVirtualMemorySize, freePhysicalMemorySize, freeSwapSpaceSize, totalPhysicalMemorySize, totalSwapSpaceSize and systemCpuLoad are machine level metrics"(processCpuLoad is JVM level metric.). But, if one can get these metrics from JMX why would he need node exporter to get these metrics?

Maybe it's no appropriate to include these metrics in 'StandardExports', but I think it will be helpful to provide these metrics in another Exports, for example OperatingSystemExports, and let the develop decide which one to use: OperatingSystemExports or node export.

@brian-brazil
Copy link
Copy Markdown
Contributor

@chanjarster chanjarster changed the title Modify StandardExports add metrics from com.sun.management.OperatingSystemMXBean add processCpuLoad metric for StandardExports Nov 6, 2018
@chanjarster
Copy link
Copy Markdown
Author

well I modified the PR just add processCpuLoad metric, that's process-level metric.

@brian-brazil
Copy link
Copy Markdown
Contributor

process_cpu_seconds_total should already cover that, and in a better way for Prometheus.

@chanjarster
Copy link
Copy Markdown
Author

Well, PR is not a good place for discussion, I created an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants