Skip to content

[issues/678] update pom.xml accordingly#679

Closed
bigmarvin wants to merge 1 commit intoprometheus:masterfrom
bigmarvin:master
Closed

[issues/678] update pom.xml accordingly#679
bigmarvin wants to merge 1 commit intoprometheus:masterfrom
bigmarvin:master

Conversation

@bigmarvin
Copy link
Copy Markdown

@bigmarvin bigmarvin commented Aug 4, 2021 •
edited
Loading

To address #678 --

  1. make the artifacts of name simpleclient_tracer_* packed as bundles
  2. make the resolution of imported packages optional by default

@fstab and @tomwilkie, may I ask you maintainers to take a look?

If possible, I'm also requesting the delivery of this fix in 0.11.x asap, as the absence of must-import packages prevents the upgrade of simpleclient in OSGi runtime.

@bigmarvin
[issues/678] update pom.xml accordingly
638f097 
1. make the artifacts of name simpleclient_tracer_* packed as bundles
2. make the resolution of imported packages optional by default

Signed-off-by: bigmarvin <[email protected]>
@bigmarvin bigmarvin changed the title [issues/678] update pom.xml accordingly [https://github.com/prometheus/client_java/issues/678] update pom.xml accordingly Aug 4, 2021
@bigmarvin bigmarvin changed the title [https://github.com/prometheus/client_java/issues/678] update pom.xml accordingly [issues/678] update pom.xml accordingly Aug 4, 2021
@bigmarvin bigmarvin changed the title [issues/678] update pom.xml accordingly [#678] update pom.xml accordingly Aug 4, 2021
@bigmarvin bigmarvin changed the title [#678] update pom.xml accordingly [issues/678] update pom.xml accordingly Aug 4, 2021
@fstab
Copy link
Copy Markdown
Member

fstab commented Aug 29, 2021

Oh, I fixed part of #678, and it seems I have overlooked that there is a PR for that. The current status on master is: I added <packaging>bundle</packaging>, but I'm unsure what *;resolution:=optional does, so I didn't add that. I guess some dependencies are not optional. Might it break things if we declare everything optional? I'm not an OSGI user, so I could use some help explaining the effect of *;resolution:=optional.

@bigmarvin
Copy link
Copy Markdown
Author

bigmarvin commented Aug 30, 2021

Oh, I fixed part of #678, and it seems I have overlooked that there is a PR for that. The current status on master is: I added <packaging>bundle</packaging>, but I'm unsure what *;resolution:=optional does, so I didn't add that. I guess some dependencies are not optional. Might it break things if we declare everything optional? I'm not an OSGI user, so I could use some help explaining the effect of *;resolution:=optional.

Great, thanks for the efforts on this! Let's continue the discussion of 2nd part in #678.

@bigmarvin bigmarvin closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigmarvin @fstab