tsdb: fix pendingCommit condition for V1 histogram append#18400
Open
cuiweixie wants to merge 1 commit intoprometheus:mainfrom
Open
tsdb: fix pendingCommit condition for V1 histogram append#18400cuiweixie wants to merge 1 commit intoprometheus:mainfrom
cuiweixie wants to merge 1 commit intoprometheus:mainfrom
Conversation
AppendHistogram used err != nil when deciding to set pendingCommit for integer histograms, while the float histogram branch uses err == nil. Align the classic histogram path so pendingCommit is set only after a successful appendableHistogram check, matching appendableFloatHistogram. Signed-off-by: Weixie Cui <[email protected]>
Member
|
Hi, thanks for this. The line you changed certainly looks better, but we'd very much prefer to see a test which demonstrates the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppendHistogramsetpendingCommitwhenappendableHistogramreturned an error, while the float histogram branch sets it only on success (err == nil). This change aligns the integer histogram path with the float histogram path for consistency.Per review: the mistaken branch is effectively unreachable in normal operation (the error path returns before effects that would make
pendingCommitobservable), so this is an internal consistency fix rather than a user-visible bugfix.