Skip to content

chore: fix unnecessary-format issues from revive#18417

Open
mmorel-35 wants to merge 2 commits intoprometheus:mainfrom
mmorel-35:revive-enable-default-rules
Open

chore: fix unnecessary-format issues from revive#18417
mmorel-35 wants to merge 2 commits intoprometheus:mainfrom
mmorel-35:revive-enable-default-rules

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Mar 31, 2026 •
edited
Loading

Which issue(s) does the PR fix:

fix unnecessary-format issues from revive

Release notes for end users (ALL commits must be considered).

Reviewers should verify clarity and quality.

NONE

@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch 2 times, most recently from 65d983d to 5cc9c01 Compare April 1, 2026 18:46
@mmorel-35 mmorel-35 marked this pull request as ready for review April 1, 2026 18:55
@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch from 5cc9c01 to 6eeb035 Compare April 1, 2026 19:02
@mmorel-35 mmorel-35 requested review from brancz and rexagod as code owners April 1, 2026 19:02
@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch 4 times, most recently from e547ef1 to ecbe800 Compare April 2, 2026 05:34
@mmorel-35 mmorel-35 requested a review from roidelapluie as a code owner April 2, 2026 05:34
@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch from ecbe800 to a326e6f Compare April 2, 2026 05:40
bboreham
bboreham reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this; generally fine but it seems like there are two or more things going on.
Could you split them into multiple PRs or at least multiple commits?

Comment thread compliance/remote_write_sender_test.go
Comment thread discovery/kubernetes/pod_test.go
Comment thread promql/parser/prettier.go Outdated
@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch 2 times, most recently from a6acd54 to 90a9782 Compare April 7, 2026 16:39
@mmorel-35 mmorel-35 force-pushed the revive-enable-default-rules branch from 90a9782 to ea6d788 Compare April 9, 2026 16:38
@mmorel-35 mmorel-35 requested a review from bboreham April 15, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

@codesome codesome Awaiting requested review from codesome codesome is a code owner

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka is a code owner

@krajorama krajorama Awaiting requested review from krajorama krajorama is a code owner

@cstyan cstyan Awaiting requested review from cstyan cstyan is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

@alexgreenbank alexgreenbank Awaiting requested review from alexgreenbank alexgreenbank is a code owner

@dgl dgl Awaiting requested review from dgl dgl is a code owner

@brancz brancz Awaiting requested review from brancz

@rexagod rexagod Awaiting requested review from rexagod

@roidelapluie roidelapluie Awaiting requested review from roidelapluie

@bboreham bboreham Awaiting requested review from bboreham

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmorel-35 @bboreham