kubernetes_sd: support daemonset metadata enrichment#18440
Open
pznamensky wants to merge 1 commit intoprometheus:mainfrom
Open
kubernetes_sd: support daemonset metadata enrichment#18440pznamensky wants to merge 1 commit intoprometheus:mainfrom
pznamensky wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: pznamensky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is related to #16747 and extends #17774
This PR is just a small improvement of what @rexagod did in his PR.
In the original PR was added ability to add name metadata for deployments, cronjobs and jobs.
It would be nice to also add name for daemosets as well.
Note: this PR has been written with help of LLMs, but I've thoroughly checked everything before submitting it (including using it in our k8s clusters).
Release notes for end users.