Skip to content

Add github access token caching mechanism, not to request token for every new api request#37

Merged
lado936 merged 2 commits intomainfrom
feature/cache-github-app-token-clean
Oct 3, 2025
Merged

Add github access token caching mechanism, not to request token for every new api request#37
lado936 merged 2 commits intomainfrom
feature/cache-github-app-token-clean

Conversation

@lado936
Copy link
Copy Markdown
Collaborator

@lado936 lado936 commented Oct 2, 2025

Description of your changes

Right now we are calling github client for every request which is an issue regarding Github api rate limits, if you have too many managed resources there is quite big possibility you will hit limit which is max 12500 requests per hour for non Enterprise org and 15000 request for Enterprise one.This change will cache api token for specific time and all clients will use it in place of requesting new one every time

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@lado936 lado936 merged commit 84ad87b into main Oct 3, 2025
6 checks passed
@lado936 lado936 deleted the feature/cache-github-app-token-clean branch October 3, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants