Conversation
bartk
commented
Nov 10, 2021
| this.basePathManager = new BasePathManager(initialConfig); | ||
| this.retrofitManager = new RetrofitManager(this); | ||
| this.listenerManager = new ListenerManager(this); | ||
| this.retrofitManager = new RetrofitManager(this); |
Contributor
Author
There was a problem hiding this comment.
I had to change the order of initialisation here. Retrofit c-tor needs ListenerManager not to be null.
Contributor
There was a problem hiding this comment.
Maybe pass listenerManager explicitly?
kleewho
previously approved these changes
Nov 10, 2021
Contributor
kleewho
left a comment
There was a problem hiding this comment.
You can address my comments but seems good enough
| @Override | ||
| public void status(@NotNull final PubNub pubnub, @NotNull final PNStatus pnStatus) { | ||
| if (pnStatus.getCategory() == PNStatusCategory.PNReconnectedCategory) { | ||
| Executors.newSingleThreadExecutor().execute(new Runnable() { |
Contributor
There was a problem hiding this comment.
Don't you think it could be better as a field? I mean the executor and here only executor.execute(...)?
| this.basePathManager = new BasePathManager(initialConfig); | ||
| this.retrofitManager = new RetrofitManager(this); | ||
| this.listenerManager = new ListenerManager(this); | ||
| this.retrofitManager = new RetrofitManager(this); |
Contributor
There was a problem hiding this comment.
Maybe pass listenerManager explicitly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Eviction of OkHttp connection pool after reestablishing connection (affects transactional calls).