Skip to content

Typed CoreFn WIP#2658

Closed
pkamenarsky wants to merge 1 commit intopurescript:masterfrom
pkamenarsky:master
Closed

Typed CoreFn WIP#2658
pkamenarsky wants to merge 1 commit intopurescript:masterfrom
pkamenarsky:master

Conversation

@pkamenarsky
Copy link
Copy Markdown
Contributor

First attempt at dumping type annotations from CoreFn.

Addresses #2657.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Feb 13, 2017

One possible problem is that we can end up with internal details like skolem constants leaking into the JSON representation. The core can probably be typed, but we don't have any documentation for what the types are, or how they correspond to the types the user wrote.

Thank you for looking at this and making the PR, but I would like to think about that problem first, which is why I put the issue under "Ideas".

@pkamenarsky
Copy link
Copy Markdown
Contributor Author

Yeah, I thought so (i.e. WIP), I was just curious how a naive dump would look like. Feel free to close if you feel the PR is premature.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Sep 9, 2017

Thank you for the PR, but I think #3049 is more up to date at this point, so I'm going to close this. Apologies for letting this bitrot, especially since we might end up going a similar route.

@paf31 paf31 closed this Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants