Closed
Conversation
Contributor
|
One possible problem is that we can end up with internal details like skolem constants leaking into the JSON representation. The core can probably be typed, but we don't have any documentation for what the types are, or how they correspond to the types the user wrote. Thank you for looking at this and making the PR, but I would like to think about that problem first, which is why I put the issue under "Ideas". |
Contributor
Author
|
Yeah, I thought so (i.e. WIP), I was just curious how a naive dump would look like. Feel free to close if you feel the PR is premature. |
Contributor
|
Thank you for the PR, but I think #3049 is more up to date at this point, so I'm going to close this. Apologies for letting this bitrot, especially since we might end up going a similar route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at dumping type annotations from CoreFn.
Addresses #2657.