Expand error message for UnusableDeclaration#3088
Merged
LiamGoodacre merged 1 commit intopurescript:masterfrom Sep 24, 2017
i-am-tom:master
Merged
Expand error message for UnusableDeclaration#3088LiamGoodacre merged 1 commit intopurescript:masterfrom i-am-tom:master
LiamGoodacre merged 1 commit intopurescript:masterfrom
i-am-tom:master
Conversation
Member
|
Thanks. Please add yourself to the contributors file. |
Previously, the error message made no mention of a solution to the error. This update adds possible solutions to the error message in the form of the remaining covering sets. In other words, the remaining variables that need to be determined in order to satisfy the typechecker.
Author
|
@LiamGoodacre Done! Also added some more TLC to the error messages, so they're hopefully a bit easier to read in the simpler case. |
Member
|
Still no mention of fundeps being the determinant? 😉 |
Member
|
Fundeps aren't necessarily involved here. Consider: class Foo t where
foo :: String |
Member
|
I mean you could argue that is like |
Contributor
|
Or |
Contributor
|
Strangely it doesn't though. |
Contributor
|
👍 Looks good to me. I think we can add an extended explanation of fundeps in the docs repo. |
LiamGoodacre
approved these changes
Sep 24, 2017
Member
@paf31 hmm, sounds like there's an issue with this edge case when we build the covering sets. |
Author
|
@paf31 It's on my list of docs to expand :) PR to follow in the next couple days! |
paf31
pushed a commit
that referenced
this pull request
Nov 8, 2017
Previously, the error message made no mention of a solution to the error. This update adds possible solutions to the error message in the form of the remaining covering sets. In other words, the remaining variables that need to be determined in order to satisfy the typechecker.
jutaro
pushed a commit
to mgmeier/purescript
that referenced
this pull request
Mar 12, 2018
Previously, the error message made no mention of a solution to the error. This update adds possible solutions to the error message in the form of the remaining covering sets. In other words, the remaining variables that need to be determined in order to satisfy the typechecker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the error message made no mention of a solution to the error. This update adds possible solutions to the error message in the form of the remaining covering sets. In other words, the remaining variables that need to be determined in order to satisfy the typechecker.
I think a couple of these changes look a bit ugly, so please do leave opinions :)