Add position information to type warning#3174
Merged
hdgarrood merged 1 commit intopurescript:masterfrom Dec 20, 2017
Merged
Conversation
Contributor
|
Could you please explain how you have tested this? |
Member
|
Yeah, it would be nice if you could come up with an example, show the bad error message on current master and then the improved one after your change. Thanks! |
Contributor
Author
|
Oops sorry I was in a hurry yesterday. For example when I have code like this: It will compile with warning:
After this PR, the warning becomes:
It's especially useful for IDE integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.