Make REPL completion tests faster#3234
Merged
kritzcreek merged 2 commits intopurescript:masterfrom Feb 17, 2018
rndnoise:faster-repl-tests
Merged
Make REPL completion tests faster#3234kritzcreek merged 2 commits intopurescript:masterfrom rndnoise:faster-repl-tests
kritzcreek merged 2 commits intopurescript:masterfrom
rndnoise:faster-repl-tests
Conversation
Member
|
@hdgarrood Do you have time to look at this one or do you want me to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than rebuild the same code for each assertion, this builds the environment once and reuses it. The whole repl set of tests went from about 35s to 10s. Now about half of the remaining time is setup done by
stack testand the other half isTestPsci(a similar optimization might be possible there, but it's less clear).