Prevent codegen when --dump-corefn is supplied#3258
Prevent codegen when --dump-corefn is supplied#3258gabejohnson wants to merge 4 commits intopurescript:masterfrom
--dump-corefn is supplied#3258Conversation
|
I tried this locally but I still see JS files being created. Perhaps I'm doing something wrong. |
|
Can I get some 👀 on this? |
|
@gabejohnson this is conflicting now #3270 has been merged - sorry, I was kinda waiting for that to go in before taking a look at this again, I probably should have mentioned! |
|
No worries. I'll rebranch from master and have another go at it. Curious though if you think we should go in this direction or the one mentioned in #3196 (comment) |
01a8e78 to
e915cd4
Compare
|
Oops, I just pushed to your branch @gabejohnson! Thought I'd branched it myself. Anyway, I updated this for latest master, but was going to tweak it a bit further to work like #3196 (comment) - I'll be sure to actually use my own branch for that. |
|
@garyb no problem. I planned to take it up again after the 0.12 release. But if you want to knock it out now, be my guest 😄 |
Fixes #3196
I opted to implement the suggestion from #3049 (comment); no JS is generated when
--dump-corefnis passed tocompile.