Makefiles make things easier for new and regular contributors alike#3266
Merged
kritzcreek merged 3 commits intopurescript:masterfrom Mar 30, 2018
bitemyapp:bitemyapp/springtime-is-make-time
Merged
Makefiles make things easier for new and regular contributors alike#3266kritzcreek merged 3 commits intopurescript:masterfrom bitemyapp:bitemyapp/springtime-is-make-time
kritzcreek merged 3 commits intopurescript:masterfrom
bitemyapp:bitemyapp/springtime-is-make-time
Conversation
Member
|
I probably won't use this much as I don't have make installed on Windows, but having a place to collect a few commonly run commands doesn't sound like a bad idea, and if it's executable for most that's a plus, so 👍 from me. |
Contributor
Author
|
@kritzcreek does this need anything else to be merged? |
Contributor
|
I forgot that this even existed when I made my own makefile PR 😮 @bitemyapp mind if I PR this branch with my |
Contributor
Author
|
@parsonsmatt go ahead! |
Contributor
|
I failed to use GitHub correctly and now my PR to your PR is borked, so I'll just update my PR after this one lands. Unless PS folks want to do it all in one go, at which point I will retry. |
Member
|
I don't mind if we do it in one or add it afterwards. This looks good to me too! @kritzcreek got any comments? |
kritzcreek
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use a
Makefilein almost all of my software projects as a sort of exobrain/secondary memory and regularized shortcut mechanism for doing common tasks. PureScript didn't have one, so I've PR'd one based on my small but burgeoning collection at https://github.com/bitemyapp/makefiles from which https://github.com/bitemyapp/lefortovo grabs things.I also updated the
.gitignoreto ignore profiling bumf.