Error positions for FFI related errors#3276
Merged
garyb merged 3 commits intopurescript:masterfrom Mar 11, 2018
Merged
Conversation
Member
|
I looked at this before, does this PR just use the full PureScript module span for all the errors then? I looked into the JS parser and the JSAnnot constructor, but I guess we just want the error span to appear in the file that caused the rebuild? |
Member
Author
|
They use the original PS module span yes. We can always improve the spans later, just ensuring they have any sensible positions is the goal for now. |
Member
|
Yeah I agree, just getting some sensible spans in there is the immediate goal. |
kritzcreek
approved these changes
Mar 11, 2018
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.