Add source spans for literals#3277
Merged
garyb merged 2 commits intopurescript:masterfrom Mar 11, 2018
Merged
Conversation
This fixes the IntOutOfRange error (again 😄)
kritzcreek
approved these changes
Mar 11, 2018
| parseObjectBinder = | ||
| LiteralBinder <$> parseObjectLiteral (indented *> parseEntry) | ||
| parseObjectBinder = withSourceSpanF $ | ||
| (flip LiteralBinder) <$> parseObjectLiteral (indented *> parseEntry) |
Member
There was a problem hiding this comment.
could drop the parens around flip LiteralBinder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the IntOutOfRange error (again 😄)
As it happens, I think it was probably unnecessary to add these, since the real problem was
literalToValueJSputtingNothingas the span for literals constantly in the JS AST... but including the spans will at least ensure the positions are accurate, and it's another step to ensuring we always have good position information.