Add compiler derived Prim.Row.Nub class#3293
Merged
garyb merged 1 commit intopurescript:masterfrom Apr 7, 2018
Merged
Conversation
Member
|
Seems like a good idea to me! |
Contributor
Author
|
I would also like to do the same for |
Member
|
If we merge #3292 first, do we want to update the type parameters to be a little more descriptive in here as well? |
Contributor
|
I've no problem to fix merge issues / update the type params for Nub on #3292 if you merge this first. |
garyb
approved these changes
Apr 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a compiler derived class for removing duplicates from rows. This is technically possible to achieve using
RowListNub, but the machinery is substantial and I think this is a common enough usecase to warrant a primitive class. This can be used to implement a more type-safe record merge than a bareUnion.