I think doing it this way is fine 👍 I have a branch with updated dependencies too, but until the Prim/Prelude record instances are in that doesn't work anyway.

I read the code that's there so far and didn't spot any obvious oversights 👍

Updated a whole bunch of tests. 😓

Getting cannot find Prim.Symbol and others like that, so I've probably missed updating something.
Will try investigating tomorrow evening.

Updated purescript-typelevel-prelude to reexport stuff from Prim submodules - but that needs more work and somewhat integrating with prelude.

Also haven't fixed tests that involve ST/Ref as I'm not sure what we're doing there.

In what sense? The ST & Ref libraries have been updated (ST being its own monad now).

Right! I'm being a moron 😸

Think there was one that used runPure, so that will need rethinking.

I guess that'll become unsafePerformEffect? 😱

Unless it's ST, in which case there is an ST.run, which is like runPure after runST / pureST.

So there's this test: examples/failing/Eff.purs

-- @shouldFailWith TypesDoNotUnify
module Main where

import Prelude
import Control.Monad.Eff
import Control.Monad.ST
import Control.Monad.Eff.Console

test = pureST (do
         ref <- newSTRef 0
         log "ST"
         modifySTRef ref $ \n -> n + 1
         readSTRef ref)

Which I believe was testing that you can't log in a pure ST.

Thoughts on what this should change to?

Similarly the passing one: examples/passing/Eff.purs

module Main where

import Prelude
import Control.Monad.Eff
import Control.Monad.ST
import Control.Monad.Eff.Console (log, logShow)

test1 = do
  log "Line 1"
  log "Line 2"

test2 = runPure (runST (do
          ref <- newSTRef 0.0
          _ <- modifySTRef ref $ \n -> n + 1.0
          readSTRef ref))

test3 = pureST (do
          ref <- newSTRef 0.0
          _ <- modifySTRef ref $ \n -> n + 1.0
          readSTRef ref)

main = do
  test1
  logShow test2
  logShow test3
  log "Done"

Wondering if these tests should just be deleted, given their focus is actually on Eff.

Wondering if these tests should just be deleted, given their focus is actually on Eff.

Yeah that sounds reasonable to me. We probably have quite a lot of redundant tests, but no harm having them unless like this they don't make sense anymore.

Thanks @kritzcreek for finishing off fixing up the tests!