Add positions for ScopeConflict caused by exports#3318
Merged
garyb merged 2 commits intopurescript:masterfrom Apr 24, 2018
Merged
Add positions for ScopeConflict caused by exports#3318garyb merged 2 commits intopurescript:masterfrom
ScopeConflict caused by exports#3318garyb merged 2 commits intopurescript:masterfrom
Conversation
Member
Author
|
There we go, much better. It's still not perfect, since for like the module Main (module A, module B) where
import A
import BIt only has the span for rather than both of them, but that's a bit harder to figure out. It's still nice that it points to at least a relevant location 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll see about improving the error spans before merging this, currently the whole-module span is used.