Skip to content

Add positions for ScopeConflict caused by exports#3318

Merged
garyb merged 2 commits intopurescript:masterfrom
garyb:scope-conflict-positions
Apr 24, 2018
Merged

Add positions for ScopeConflict caused by exports#3318
garyb merged 2 commits intopurescript:masterfrom
garyb:scope-conflict-positions

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented Apr 24, 2018

I'll see about improving the error spans before merging this, currently the whole-module span is used.

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Apr 24, 2018

There we go, much better. It's still not perfect, since for like the ConflictingExports example

module Main (module A, module B) where

import A
import B

It only has the span for

module Main (module A, module B) where
             ^^^^^^^^

rather than both of them, but that's a bit harder to figure out. It's still nice that it points to at least a relevant location 😄

@garyb garyb merged commit fcf793e into purescript:master Apr 24, 2018
@garyb garyb deleted the scope-conflict-positions branch April 24, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant