Skip to content

[purs ide] Extracts documentation comments for type classes#3856

Merged
kritzcreek merged 2 commits intopurescript:masterfrom
kritzcreek:ide-typeclass-docs
Apr 26, 2020
Merged

[purs ide] Extracts documentation comments for type classes#3856
kritzcreek merged 2 commits intopurescript:masterfrom
kritzcreek:ide-typeclass-docs

Conversation

@kritzcreek
Copy link
Copy Markdown
Member

I had assumed we were already doing this? Maybe something about the Name structure changed, or this was just an oversight in the original PR. I also added a test to make sure it doesn't regress.

I had assumed we were already doing this? Maybe something about the
Name structure changed.
Copy link
Copy Markdown
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kritzcreek
Copy link
Copy Markdown
Member Author

Thanks!

@kritzcreek kritzcreek merged commit e164eaa into purescript:master Apr 26, 2020
@kritzcreek kritzcreek deleted the ide-typeclass-docs branch April 26, 2020 21:29
@hdgarrood hdgarrood mentioned this pull request May 23, 2020
hdgarrood pushed a commit that referenced this pull request May 23, 2020
* [purs ide] Extracts documentation comments for type classes

I had assumed we were already doing this? Maybe something about the
Name structure changed.

* [purs ide] Extracts documentation comments for type class members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants