Skip to content

Prep repo for next release#54

Merged
JordanMartinez merged 5 commits intomasterfrom
finish-repo
Jul 19, 2023
Merged

Prep repo for next release#54
JordanMartinez merged 5 commits intomasterfrom
finish-repo

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

@JordanMartinez JordanMartinez commented Jul 18, 2023

Description of the change

Final changes before making a new breaking release.

  • I noticed the license file was a bit outdated, especially now that node-streams-aff is integrated into this repo. I've added James explicitly to the list of people there and people in the node-purescript GH org generically. DICOM Grid, Inc. AFAIK hasn't contributed to this repo for quite some time, or at least, I'm not aware of who works for them and has contributed to this repo during company time.
  • The Main3 test wouldn't fail if the expected count differed. I've updated it to account for that now.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

JordanMartinez commented Jul 18, 2023

CI is failing AFAICT because of the usage of spec in our tests due to integrating node-streams-aff into this repo. Running things locally after clearing my bower cache, I get the following interactive prompt:

Unable to find a suitable version for purescript-node-buffer, please choose one by typing one of the numbers below:
    1) purescript-node-buffer#^8.0.0 which resolved to 8.0.0 and is required by purescript-node-fs#8.2.0, purescript-node-streams#7.0.0
    2) purescript-node-buffer#^v8.0.0 which resolved to 8.0.0 and is required by purescript-spec#7.5.2
    3) purescript-node-buffer#^9.0.0 which resolved to 9.0.0 and is required by purescript-node-streams

Spec depends on node-fs and node-streams, so we have a cyclical dependency here. Even if I do override it to use [email protected], there's still breaking changes that will likely cause spec to fail to build/execute correctly.

@jamesdbrock Thoughts on how I should deal with this? While it won't be as pretty, a ReaderT Int Aff-based test setup should get us enough pretty-printing to be more legible than just using plain assert, but not by much.

@JordanMartinez JordanMartinez mentioned this pull request Jul 19, 2023
Merged
@JordanMartinez
Copy link
Copy Markdown
Contributor Author

JordanMartinez commented Jul 19, 2023

Looks like spec just declares its test deps incorrectly in its bower.json file. See the PR linked above.

@JordanMartinez JordanMartinez merged commit 1e15a3f into master Jul 19, 2023
@JordanMartinez JordanMartinez deleted the finish-repo branch July 19, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JordanMartinez