Skip to content

Bump to 3.4.0#459

Merged
jjlawren merged 1 commit intopushingkarmaorg:masterfrom
jjlawren:bump_3.4.0
Apr 17, 2020
Merged

Bump to 3.4.0#459
jjlawren merged 1 commit intopushingkarmaorg:masterfrom
jjlawren:bump_3.4.0

Conversation

@jjlawren
Copy link
Copy Markdown
Collaborator

No description provided.

@jjlawren jjlawren merged commit 74ae49e into pushingkarmaorg:master Apr 17, 2020
@jjlawren jjlawren deleted the bump_3.4.0 branch April 17, 2020 16:03
@pkkid
Copy link
Copy Markdown
Collaborator

pkkid commented Apr 17, 2020

This didn't make it to PyPi. Do we need to tag it or do some Github magic?

@jjlawren
Copy link
Copy Markdown
Collaborator Author

Maybe because I added the release/tag after committing the PR. I'm trying a manual Travis build now: https://travis-ci.org/github/pkkid/python-plexapi/builds/676296441.

@jjlawren
Copy link
Copy Markdown
Collaborator Author

The travis job reported:

stages: skipping stage #2 because its condition does not match: tag = present

I'm guessing we should do one of two things:

  1. Change the stage condition from tag = present to tag IS present (https://docs.travis-ci.com/user/conditions-v1)
  2. Remove the stage condition since the deploy step is already condition-based with on: tags: true. (https://docs.travis-ci.com/user/deployment#conditional-releases-with-on)

@Hellowlol
Copy link
Copy Markdown
Collaborator

I think we should remove 1 and just let the deploy handle it

@jjlawren
Copy link
Copy Markdown
Collaborator Author

Updated in #460. It might need a fresh tag to trigger once that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants