Adding season and episode number to Season and Episode objects#55
Closed
ttufts wants to merge 1 commit intopushingkarmaorg:masterfrom
Closed
Adding season and episode number to Season and Episode objects#55ttufts wants to merge 1 commit intopushingkarmaorg:masterfrom
ttufts wants to merge 1 commit intopushingkarmaorg:masterfrom
Conversation
…Index' in as episode_number and season_number respectively. This works for almost all situations, except when all episodes are pulled from a Show object, without going through seasons, the solution here is to check for 'parentIndex' when building the Episode object, if it is missing, the season() function is called and the season_number is pulled in from the Season object. This works in every situation that you can access an Episode or Season object, whether directly from the Show, or from the Season object.
Collaborator
|
A implemented it slightly differently, but kept the main idea you had here. I realize what originally happened was during the v2 update last month I inadvertently removed the self.index attribute from the Show, Season, and Episode classes which had me confused and broke the old method of getting the season numbers. Anyway, thanks for the bug report and code! Let me know if this change works for you. commit 36b5d12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added season_number and episode_number by pulling 'index' and 'parentIndex' in as episode_number and season_number respectively. This works for almost all situations, except when all episodes are pulled from a Show object, without going through seasons, the solution here is to check for 'parentIndex' when building the Episode object, if it is missing, the season() function is called and the season_number is pulled in from the Season object. This works in every situation that you can access an Episode or Season object, whether directly from the Show, or from the Season object.