Do not treat parentheses as special characters when parsing inner query#5
Merged
florianschieder merged 4 commits intomainfrom Apr 10, 2026
Merged
Do not treat parentheses as special characters when parsing inner query#5florianschieder merged 4 commits intomainfrom
florianschieder merged 4 commits intomainfrom
Conversation
468d373 to
2ce8648
Compare
wfehr
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlqueryppissues a parser state transition when it sees(and).This is correct behavior, but NOT when we are within the
{ ... }scope, because within that scope(and)are evaluated in MySQL, notsqlquerypp. Otherwise,sqlquerypptries to unroll the state back to the combinator expression and the confusion is confused.This led to errors when extending a
sqlquerypp-preprocessed query which previously containedAND something = 'foo'toAND something IN ('bar', 'foo').The fix is quite simple: introducing a new state variable and skipping the
TokenState::OpeningParenthesetransition in case we are already within the{ ... }scope which contains the SQL query to combine.