Open
Conversation
for more information, see https://pre-commit.ci
|
Thank you for your efforts in implementing CMPNN. Based on my tests, this pull request correctly implements the key modules described in the original paper. One question I have is whether it would be more appropriate to separate BatchGRU from CMPNN, considering that BatchGRU serves the role of a readout function. |
Contributor
Author
|
Thank you @AzureLeon1 for taking the time to review the PR. Regarding the
I feel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper Summary
Motivation
Benchmark Results
I have benchmarked CMPNN on a subset of datasets from the TDC ADMET Benchmark Group. I have used LitGNN to perform this benchmark and results can be found in a W&B report.
CMPNN-GRU
CMPNN-MLP
CMPNN-GRU
CMPNN-MLP
CMPNN-Additive
Table: Prediction results of CMPNN on five chemical graph datasets. The datasets were used from the TDC ADMET Benchmark group that provides train_val/test scaffold splits. The model was trained and tested for each task for five times, and reported the mean and standard deviation of AUROC or MAE values. *Chemprop-RDKIT utilizes a hybrid approach where it combines the learned molecule embeddings with 200 global molecule features (descriptors).
Implementation Details
Note
Here is a fork of the original code with some cleanups, addition of poetry for dependency management etc.
Below are the places where improvements have been made:
Checklist
Note
For
CMPNNPyG implementation, I have usedAttentiveFPas a template.torch_geometric/nn/models/cmpnn.pyCMPNNtotorch_geometric/nn/models/__init__.pytest/nn/models/test_cmpnn.pymessage_boostermode to thetorch_geometric/nn/aggr/multi.py:MultiAggregationclassmessage_boostermode intest/nn/aggr/test_multi.pyexamples/cmpnn.pyThank you! Please let me know if any changes are required.